aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthias Welwarsky <matthias.welwarsky@sysgo.com>2016-11-27 11:28:01 +0100
committerPaul Fertser <fercerpav@gmail.com>2017-02-24 09:14:32 +0000
commit8b923532c16459d83655bab418b92e57f6d3312a (patch)
treeb75e85d1c45a3eba3a9b3a1ba06a7b0ec174d9b1
parent9527d1e595e316a4155c808fafa3a0ea6baa72f2 (diff)
aarch64: remove bogus address check before memory access
Mmu faults can not be prevented on aarch64, they need to be taken and handled accordingly. Remove the remaining stub code. Change-Id: I6241efa594fe6b963624f9628cdf1c8e46588223 Signed-off-by: Matthias Welwarsky <matthias.welwarsky@sysgo.com> Reviewed-on: http://openocd.zylin.com/3987 Tested-by: jenkins Reviewed-by: Paul Fertser <fercerpav@gmail.com>
-rw-r--r--src/target/aarch64.c13
1 files changed, 0 insertions, 13 deletions
diff --git a/src/target/aarch64.c b/src/target/aarch64.c
index d3ed57c..5dd6d7a 100644
--- a/src/target/aarch64.c
+++ b/src/target/aarch64.c
@@ -103,13 +103,6 @@ static int aarch64_restore_system_control_reg(struct target *target)
return retval;
}
-/* check address before aarch64_apb read write access with mmu on
- * remove apb predictible data abort */
-static int aarch64_check_address(struct target *target, uint32_t address)
-{
- /* TODO */
- return ERROR_OK;
-}
/* modify system_control_reg in order to enable or disable mmu for :
* - virt2phys address conversion
* - read or write memory in phys or virt address */
@@ -1651,9 +1644,6 @@ static int aarch64_read_memory(struct target *target, target_addr_t address,
return retval;
if (mmu_enabled) {
- retval = aarch64_check_address(target, address);
- if (retval != ERROR_OK)
- return retval;
/* enable MMU as we could have disabled it for phys access */
retval = aarch64_mmu_modify(target, 1);
if (retval != ERROR_OK)
@@ -1691,9 +1681,6 @@ static int aarch64_write_memory(struct target *target, target_addr_t address,
return retval;
if (mmu_enabled) {
- retval = aarch64_check_address(target, address);
- if (retval != ERROR_OK)
- return retval;
/* enable MMU as we could have disabled it for phys access */
retval = aarch64_mmu_modify(target, 1);
if (retval != ERROR_OK)